Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcd v3.4 cluster works #135

Merged
merged 1 commit into from
May 20, 2021
Merged

Fix etcd v3.4 cluster works #135

merged 1 commit into from
May 20, 2021

Conversation

ainoniwa
Copy link
Contributor

@ainoniwa ainoniwa commented Oct 17, 2020

This is fix to #127

In etcd v3.4 cluster, required to wait for leader election before serve client.
So, all etcd process need to exec with wait_for_line="listening for peers on" instead wait_for_line="ready to serve client requests".

Additional:

- etcdctl use etcd v3 API (ETCDCTL_API=3)
- travis to use etcd v3.4.13
@jd
Copy link
Owner

jd commented Oct 18, 2020

I guess this is going to break older etcd versions. Is this fine?

@ainoniwa
Copy link
Contributor Author

ainoniwa commented Oct 19, 2020

Thank you for review it.
This PR will compatible etcd v3.0 or higher. I tested v3.2.31/v3.3.25/v3.4.13, and each etcd UT passed.

In etcd v3.4, ETCDCTL_API=3 is default. so use etcdctl endpoint health is work.
In etcd v3.3 or older, ETCDCTL_API=2 is default. but v3 API is already. so it can use etcdctl cluster-health or export ETCDCTL_API=3; etcdctl endpoint health.

Or, do you mind about other parts?

@jd
Copy link
Owner

jd commented Oct 22, 2020

Ok, that sounds great! Thank you!

@jd jd closed this Dec 2, 2020
@jd jd reopened this Dec 2, 2020
@felixonmars
Copy link
Collaborator

Confirmed that it works with etcd 3.4.15 here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants