Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme support #94

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

tpenguinltg
Copy link

@tpenguinltg tpenguinltg commented Jun 20, 2020

Reopening #39 after the master to main rename closed it. See the original PR for a description and test themes.

Closes #33

@vercel
Copy link

vercel bot commented Jun 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jdan/98css/CPkQFeZBAoEqyMCVviYqU8amPaGv
✅ Preview: https://98css-git-fork-tpenguinltg-theme-support-jdan.vercel.app

@tpenguinltg
Copy link
Author

tpenguinltg commented Mar 16, 2021

In light of #107, I've updated this pull request to the tip of main. It was surprisingly a fairly painless rebase, so things should still work the same as it did last year (a quick check suggests so as well). SVG colours are still not handled, and as a reminder, additional info can be found in the original PR (#39).

Support the full range of configurable colors in a Windows Classic
theme. The colors are configured using CSS variables named after the
corresponding Windows theme file property converted from PascalCase to
kebab-case.

Colors are given in rgb format to make it easier to convert and
recognize values from a Windows theme file.

The old variables are kept for backwards compatibility and are mapped
accordingly. However, the old `--button-face`, which maps to
`--button-light`, has not been mapped because of a name conflict with
the new `--button-face`; this is a breaking change.
Remove the radio width from the calculation for the radio dot top value.
I'm not sure why this works, but it does.

Also remove redundant precalc variables. Nested calc calls are reduced
to a single one automatically.
The computed asset, 98.css, precomputes the values that uses CSS
variables. The non-computed asset, 98-full.css, preserves the variables
and uses the computed values as fallbacks for browsers without support
for custom properties.
@quinn
Copy link

quinn commented Feb 27, 2024

Assuming it works with vars, it looks like https://www.npmjs.com/package/postcss-inline-svg can apply transforms to the SVGs as they are being bundled/inlined. So this could be used to compile themes (but not for theming at runtime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme support
2 participants