-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameterize all colors in css #107
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/348JHLLmynpm6AYUmNXp6Eph8VKi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, good idea! Two comments inline.
width: 8px; | ||
height: 9px; | ||
line-height: 8px; | ||
margin-right: 5px; | ||
padding-left: 1px; | ||
background-color: #fff; | ||
background-color: var(--control-outline); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here I believe?
@@ -686,7 +694,7 @@ code * { | |||
} | |||
|
|||
summary:focus { | |||
outline: 1px dotted #000000; | |||
outline: 1px dotted (--control-outline); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing var
My apologies - a lot of work has already been done in #94 so I'm going to close this as a dupe and revisit that one. Feel free to chime in there with any ideas. |
This PR parameterizes all colors in the main
style.css
file. Ideally I'd say this was to make everything more consistent, but in reality it will make future work to theme on top of this much easier (e.g., Dark Windows 98 theme? Yes, please.) I tried to re-use existing color variables where possible, and introduced others where neccesary.This doesn't address colors in the SVG icons, so that's left as an exercise for a future day.
No output differences were observed in the display of the sample
index.html.ejs
file, but other eyes are certainly welcome.