Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setAttachAllStatementsForCleanup flag #2294

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

hgschmie
Copy link
Contributor

Allows all statements to be attached to their handle by default and cleaned up when the handle closes.

Addresses #2293.

@jodastephen would that work for your use case?

Copy link

@jodastephen jodastephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. thanks

@hgschmie
Copy link
Contributor Author

@stevenschlansker any opinion?

@hgschmie hgschmie force-pushed the issue-2293 branch 2 times, most recently from 60d6734 to c9f0759 Compare March 20, 2023 01:16
Allows all statements to be attached to their handle by default and cleaned up
when the handle closes.
Allows all statements created within Jdbi callback methods to be attached to their handle
by default and cleaned up when the handle closes. This flag is set by default and must be
explicitly cleared if the behavior is not desired.
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hgschmie hgschmie merged commit 16bcb49 into jdbi:master Mar 20, 2023
@hgschmie hgschmie deleted the issue-2293 branch March 20, 2023 01:48
@stevenschlansker
Copy link
Member

Seems reasonable enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants