Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This turns the whole background shape the same color as indicator for FlowChart diagram nodes #255

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

tolzhabayev
Copy link
Contributor

@tolzhabayev tolzhabayev commented Feb 22, 2024

In previous (angular) version this seem to have been the default behaviour.

Main change:

  • For those who have set the option
    "Use shape background for metric indicator" to true and only affects Flow Charts

Additional changes:

  • Adding some padding to flow chart nodes
  • Reseting label text size and line-height to avoid text nodes sticking out of the box
  • Added scrolling to those flowchart diagrams that have no maxWidth enabled so that they can overflow and still be used by scrolling up and down
  • Fixed element selection by id if alias contains characters not allowed for id. It was erroring out with something like SyntaxError: Failed to execute 'querySelector' on 'Element': '#current_%' is not a valid selector.

Before:
SCR-20240222-lgga

After:
SCR-20240222-lgaq

@tolzhabayev tolzhabayev changed the title This turns the whole background shape the same color as indicator This turns the whole background shape the same color as indicator for FlowChart diagram nodes Feb 22, 2024
@ahmadalli
Copy link
Contributor

@jdbranham Can you please take a look at this PR along with #254 and #253?
These MRs fix the following issues:

@jdbranham jdbranham merged commit ad7ed4b into jdbranham:master Mar 5, 2024
1 of 2 checks passed
@tolzhabayev
Copy link
Contributor Author

tolzhabayev commented Mar 20, 2024

Hey @jdbranham, thanks for submitting an update to our catalog. We have provided your (per email) some fixes to address (especially the signing part) - and once they are done and resubmitted we can go ahead and publish a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants