Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/edit image secrets paths #28

Merged
merged 6 commits into from
Jun 15, 2023
Merged

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented Jun 15, 2023


Fixed regex to be more general, small refactor of code to do so. Tested with Olya's code examples and SAS example.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aosm nfd build --config-file cnf_input.json --definition-type cnf

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jordlay jordlay merged commit b19dcc3 into add-aosm-extension Jun 15, 2023
@jamiedparsons jamiedparsons deleted the jl/edit-image-secrets-paths branch July 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants