Adding support for whenSettled to DeferredManager (Promise.allSettled) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice! We'll likely move this to 2.x. It's on the roadmap here: That being said, some of the breaking changes were significant. Would it be possible to only have whenSettled(...) method for the 2.x branch? |
|
Indeed, the changes make more sense for the |
mrmaffen
force-pushed
the
whenSettled
branch
from
5e2390c
to
6076c0a
Compare
|
@saturnism There shouldn't be any breaking changes. Which changes are you referring to? |
|
I believe @saturnism is referring to the breaking changes we made in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
in addition to my codestyle PR I have added support for whenSettled to DeferredManager and its children. This is basically equivalent to Promise.allSettled. whenSettled waits for all Promises to either get resolved or rejected and then returns all results in the correct order.
Current functionality should remain untouched by my commits.
I have compiled and tested jdeferred in my Android App project.
This change is