Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add configuration option to prevent persisting selected properties #97

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

atnstefan commented Feb 23, 2014

This is useful for cases where the session stores some transient data required only for the current request. The transient data needs to be pre-configured via ignoredProperties option.

atnstefan added some commits Feb 23, 2014

Add configuration option to prevent persisting selected properties.
This is useful for cases where the session stores some transient data required only for the current request. The transient data needs to be pre-configured via ignoredProperties option.
Rename ignoredProperty to transientProperty to further clarify the pu…
…rpose. Also add documentation about the property.

@atnstefan atnstefan closed this Feb 23, 2014

@atnstefan atnstefan reopened this Feb 23, 2014

Collaborator

kcbanner commented Apr 4, 2014

Thanks! I'll take a look at this ASAP

Contributor

atnstefan commented May 10, 2014

Any chance of getting this merged and released?

Owner

jdesboeufs commented Dec 18, 2014

This feature should take place in express-session.
I can re-open this PR if needed.

@jdesboeufs jdesboeufs closed this Dec 18, 2014

Contributor

atnstefan commented Dec 19, 2014

Persistence discrimination should be done in the persistence layer. From a design perspective, the session has no knowledge how and where the session is persisted. A session persisted in memory will be more likely to store very little data, whereas one stored on disk could store all the data. The session does not need to know all these details.

Can you please re-open and merge this PR into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment