Add configuration option to prevent persisting selected properties #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for cases where the session stores some transient data required only for the current request. The transient data needs to be pre-configured via ignoredProperties option.
…rpose. Also add documentation about the property.
|
Thanks! I'll take a look at this ASAP |
|
Any chance of getting this merged and released? |
|
This feature should take place in express-session. |
|
Persistence discrimination should be done in the persistence layer. From a design perspective, the session has no knowledge how and where the session is persisted. A session persisted in memory will be more likely to store very little data, whereas one stored on disk could store all the data. The session does not need to know all these details. Can you please re-open and merge this PR into the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for cases where the session stores some transient data required only for the current request. The transient data needs to be pre-configured via ignoredProperties option.