Ported some examples of File IO into Python mode #236
Conversation
| def draw(): | ||
| global index | ||
| pieces = [] | ||
| if (index < len(lines)): |
There was a problem hiding this comment.
No need for java-isms like parens around conditionals.
| if (index < len(lines)): | ||
| pieces = split(lines[index], '\t') | ||
| if (len(pieces) == 2): | ||
| x = int(pieces[0]) * 2 |
There was a problem hiding this comment.
I took this as is from the example in the Java mode. I think this was done because the inputs are in the range of 0-99 whereas the canvas was of size 200 X 200. Should I remove it?
|
|
||
| lines = loadStrings("cars2.tsv") | ||
| records = [] | ||
| for i in xrange(len(lines)): |
| global recordCount | ||
| global records | ||
| global num | ||
| global startingEntry |
There was a problem hiding this comment.
None of these global statements are needed
|
|
||
| def mousePressed(): | ||
| global records | ||
| global num |
There was a problem hiding this comment.
no need for global statements for records and num
| for i in xrange(len(lines)): | ||
| pieces = split(lines[i], TAB) # Load data array | ||
| if (len(pieces) == 9): | ||
| for line in xrange(len(lines)): |
There was a problem hiding this comment.
for line in lines:
no need to use indexes
| for line in lines: | ||
| pieces = split(line, TAB) # Load data array | ||
| if len(pieces) == 9: | ||
| records.insert(recordCount, Record(pieces)) |
There was a problem hiding this comment.
why not just records.append(Record(pieces)) ?
|
|
||
|
|
||
| def setup(): | ||
| global recordCount |
There was a problem hiding this comment.
This variable is unnecessary; just use len(records)
| def setup(): | ||
| global recordCount | ||
| global records | ||
| global num |
| 20, | ||
| 20 + | ||
| index * | ||
| 20) |
There was a problem hiding this comment.
text("%d > %s" % (thisEntry, records[thisEntry].name), 20, 20 * index * 20)
| beginShape() | ||
| for i in xrange(len(x)): | ||
| vertex(x[i], y[i]) | ||
|
|
| def keyPressed(): # Press a key to save the data | ||
| lines = [] | ||
| for i in xrange(len(x)): | ||
| lines.insert(i, str(x[i]) + "\t" + str(y[i])) |
There was a problem hiding this comment.
lines.append("%d\t%d" % (x[i], y[i]))
|
|
||
| # An arbitrary oscillating rotating animation | ||
| # so that we have something to render | ||
| for a in xrange(0, TWO_PI, 1): |
There was a problem hiding this comment.
This shouldn't even run; I don't think you can use a foating point number in a range statement. Have you run these programs?
There was a problem hiding this comment.
I did run this program and it gave the correct output, but I understand, i'll change this to something more appropriate
| 20) | ||
|
|
||
| if thisEntry < len(records): | ||
| text("%d > %s" % (thisEntry, records[thisEntry].name), 20, 20 + index * 20) |
| 20, | ||
| 20 + | ||
| index * | ||
| 20) |
There was a problem hiding this comment.
Did the auto-format do this strange formatting?
There was a problem hiding this comment.
I used autopep8 for the formatting. Is it wrong?
There was a problem hiding this comment.
I tried using autoformat from the PDE and it shows no changes needed. Am i doing something wrong?
There was a problem hiding this comment.
Here is how these lines should be formatted:
if thisEntry < len(records):
text("%d > %s" %
(thisEntry, records[thisEntry].name), 20, 20 + index * 20)There was a problem hiding this comment.
Thank you, I have made the changes.
| global startingEntry | ||
| startingEntry += numEntries | ||
| if startingEntry > len(records): | ||
| startingEntry=0 # go back to the beginning |
There was a problem hiding this comment.
All files need to be correctly formatted.
There was a problem hiding this comment.
Made the change. Thank you.
|
|
||
| # An arbitrary oscillating rotating animation | ||
| # so that we have something to render | ||
| for a in xrange(0, 6, 1): |
There was a problem hiding this comment.
This is not how Daniel Shiffman's example works; goes between 0 and 2pi by 0.2 at a time.
I don't have time to evaluate every line of code in this pull request, and I don't think there's anything to be gained from further work. I'm sorry you've spent so much time on it, but I'm closing this request.
referencing issue: jdf/Processing.py-Bugs#4