Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing 3.5.3 new methods #337

Merged
merged 6 commits into from Feb 7, 2019
Merged

Conversation

berinhard
Copy link
Contributor

Fixes #336

This PR add the new methods added by Processing 3.5.3 and also enable the use of push and pop as context managers.

I struggled with the build process, but I wasn't successful. I'm always running into this error:

BUILD FAILED
/home/bernardo/workspace/processing.py/build.xml:216: The following error occurred while executing this line:
/home/bernardo/workspace/processing/build/build.xml:57: Unsupported Java version: 10.0.2. To build, make sure that Java 8 (aka Java 1.8) is installed.

Even though I have Java 8 installed and my JAVA_HOME env var set to use my Java 8 installation. I'm not that familiar with Java and a lot of posts I read on Stackoverflow suggests me to use an IDE to build instead of the command line.

@berinhard berinhard changed the title Feature/new methods Add processing 3.5.3 new methods Feb 6, 2019
@jdf
Copy link
Owner

jdf commented Feb 6, 2019

Could you add a test that exercise push() and pop()? I don't even know what they do. :)

@jdf
Copy link
Owner

jdf commented Feb 6, 2019

I'm guessing there's a java 10 in your $PATH.

@berinhard
Copy link
Contributor Author

@jdf PR updated =]

I added new tests for the circle method and also for the push/pop as well. They're passing for me as you can see in this print:

screenshot from 2019-02-07 13-24-31

I also have a question. Should I also add those new methods to the keywords.txt file?

@jdf
Copy link
Owner

jdf commented Feb 7, 2019

Nice work; thank you.

@jdf jdf merged commit 57f6e4d into jdf:master Feb 7, 2019
@jdf
Copy link
Owner

jdf commented Feb 7, 2019

Oops; missed your question. Yes, it would be great to have new keyword lighlighting too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants