-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dialog): 增加 lock-scroll 说明 #3082
Conversation
Walkthrough此次更新在 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4 #3082 +/- ##
==========================================
- Coverage 83.99% 83.96% -0.04%
==========================================
Files 226 226
Lines 22939 22939
Branches 2476 2478 +2
==========================================
- Hits 19268 19261 -7
- Misses 3653 3660 +7
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
src/packages/__VUE/dialog/doc.taro.md (2)
Line range hint
147-148
: 请修正属性表中的引号不匹配问题,以确保文档格式正确无误。- | cancel-text | 取消按钮文案 | string | `”取消“` | - | ok-text | 确定按钮文案 | string | `”确 定“` | + | cancel-text | 取消按钮文案 | string | `"取消"` | + | ok-text | 确定按钮文案 | string | `"确 定"` |
110-110
: 建议检查文档中的标题层级,确保它们逐级递增,以便读者更好地理解结构。
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/packages/__VUE/dialog/doc.taro.md (1 hunks)
Additional Context Used
LanguageTool (2)
src/packages/__VUE/dialog/doc.taro.md (2)
Near line 147: Unpaired symbol: ‘“’ seems to be missing
Context: ...se| | cancel-text | 取消按钮文案 | string |
”取消“| | ok-text | 确定按钮文案 | string |
”确...
Near line 148: Unpaired symbol: ‘”’ seems to be missing
Context: ...”取消“
| | ok-text | 确定按钮文案 | string |”确 定“
| | cancel-auto-close | 取消按钮是否默认关闭弹窗 |...
Additional comments not posted (2)
src/packages/__VUE/dialog/doc.taro.md (2)
110-132
: 新增的lock-scroll
属性说明和示例清晰明了,能够很好地帮助用户理解如何使用此功能。
Line range hint
183-183
: 请确认链接#/zh-CN/component/configprovider
是否正确,以确保用户能够正确导航到ConfigProvider
组件的文档。
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
这个 PR 是否已自测:
Summary by CodeRabbit
lock-scroll
属性,默认情况下允许锁定背景以防止滚动穿透。