Add Unit Testing and Formatter #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds unit tests with 100% test coverage
This commit mostly formats the files according to black's standards. It also sorts imports according to isort. A GitHub workflow was added to format on a push and a pre-commit config was added to run formatting before a commit. Lastly, a test in `test_account` was fixed because it was not working in python 3.7
Add paths/branches so the workflows only run when we want them to Also, fail the test workflow if the coverage is under 100%
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few developer conveniences, but no features to the actual script.
The following was added:
My goal is to keep this project at 100% test coverage by adding new tests in the same commit (or the next one) as a feature implementation.
I also will consider adding a workflow to lint the application using pylint