Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate ignoring time and timezone values #1

Merged
merged 1 commit into from
May 31, 2016
Merged

Calculate ignoring time and timezone values #1

merged 1 commit into from
May 31, 2016

Conversation

ahelmberger
Copy link
Contributor

The calculation can yield incorrect results in case the time part of the input date is not 00:00:00. This PR should fix it.

@coveralls
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d8105ff on CHECK24:time-fix into 15a6b23 on jdiehl:master.

@ahelmberger
Copy link
Contributor Author

Unfortunately, there seems to be some problem with coveralls (see: lemurheavy/coveralls-public#487). I'm getting this error all the time, even without my changes.

@jdiehl jdiehl merged commit 98bbb2a into jdiehl:master May 31, 2016
@jdiehl
Copy link
Owner

jdiehl commented May 31, 2016

Great catch! Thanks!

@ahelmberger
Copy link
Contributor Author

You're very welcome. And thanks for this very useful little library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants