Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate ignoring time and timezone values #1

Merged
merged 1 commit into from
May 31, 2016
Merged

Calculate ignoring time and timezone values #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion holiday-de.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
var year = date.getFullYear();
var tsYearStart = new Date(year, 0, 1).valueOf();
var easterDays = Math.round((calculateEasterSunday(year).valueOf() - tsYearStart) / 86400000);
var diff = Math.round((date.valueOf() - tsYearStart) / 86400000) - easterDays;
var diff = Math.round((new Date(year, month, day).valueOf() - tsYearStart) / 86400000) - easterDays;

function checkVar(name, d) {
return exports.holidays[name] && diff === d ? name : false;
Expand Down
25 changes: 25 additions & 0 deletions test/holiday-de.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,31 @@ describe('#holiday-de', function () {
});
});

describe('neglecting time and time zone', function () {
beforeEach(function () { holiday.setState('by'); });
afterEach(function () { holiday.resetHolidays(); });
it('isHoliday() should not identify holidays one second before they start', function () {
var test = holiday.isHoliday(new Date(2016, 4, 25, 23, 59, 59));
console.assert(test === false, '2016-05-25 23:59:59 should not be a holiday');
});
it('isHoliday() should identify holidays as soon as they start', function () {
var test = holiday.isHoliday(new Date(2016, 4, 26, 0, 0, 0));
console.assert(test, '2016-05-26 00:00:00 should be a holiday');
});
it('isHoliday() should identify holidays at noon', function () {
var test = holiday.isHoliday(new Date(2016, 4, 26, 12, 0, 0));
console.assert(test, '2016-05-26 12:00:00 should be a holiday');
});
it('isHoliday() should identify holidays one second before they are over', function () {
var test = holiday.isHoliday(new Date(2016, 4, 26, 23, 59, 59));
console.assert(test, '2016-05-26 23:59:59 should be a holiday');
});
it('isHoliday() should not identify holidays as soon as they are over', function () {
var test = holiday.isHoliday(new Date(2016, 4, 27, 0, 0, 0));
console.assert(test === false, '2016-05-27 00:00:00 should not be a holiday');
});
});

describe('moment', function () {
beforeEach(function () { holiday.setState('nw'); });
it('isHoliday() should support a moment object', function () {
Expand Down