Skip to content

Commit

Permalink
🤖 Merge PR DefinitelyTyped#46373 mailgun-js: Adds delete method to ma…
Browse files Browse the repository at this point in the history
…ilinglists by @gstvds

* feat: Adds delete method to mailinglists

* tests: Add delete list test
  • Loading branch information
gstvds committed Jul 27, 2020
1 parent 2e0ccd5 commit 182b6ee
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions types/mailgun-js/index.d.ts
Expand Up @@ -247,10 +247,16 @@ declare namespace Mailgun {
delete: MailgunRequest;
}

interface DeleteResponse {
address: string;
message: string;
}

interface Lists {
info(callback?: (error: Error, data: any) => void): Promise<any>;
members(): lists.Members;
members(member: string): lists.Member;
delete(callback?: (error: Error, body: DeleteResponse) => void): Promise<DeleteResponse>;
}

interface Messages {
Expand Down
4 changes: 3 additions & 1 deletion types/mailgun-js/mailgun-js-tests.ts
Expand Up @@ -142,7 +142,9 @@ const validationResult6: mailgunFactory.validation.ValidateResponse = {
};

// Generic requests
mailgun.get('/samples.mailgun.org/stats', { event: ['sent', 'delivered'] }, (error: any, body: any) => {});
mailgun.get('/samples.mailgun.org/stats', (error: any, body: any) => {});
const response1: Promise<any> = mailgun.get('/samples.mailgun.org/stats', { event: ['sent', 'delivered'] });
const response2: Promise<any> = mailgun.get('/samples.mailgun.org/stats');

// Delete mailing list
mailgun.lists('example@mailgun.net').delete((error, body) => { });

0 comments on commit 182b6ee

Please sign in to comment.