/Comet

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate events recorded #30

Closed
jdswinbank opened this Issue Jul 5, 2014 · 1 comment

Comments

Assignees

@jdswinbank jdswinbank

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jdswinbank
@jdswinbank
Owner

jdswinbank commented Jul 5, 2014

When subscribing to multiple brokers which all send the same event, Comet should process the first copy of that event to be received and drop the others. However, sometimes an extra copy slips through. For example:

2014-07-05 11:34:36+0200 [INFO VOEventSubscriber,client] VOEvent ivo://nasa.gsfc.gcn/SWIFT#XRT_Proc_Spec_603488-809 received from IPv4Address(TCP, '209.208.78.170', 8099)
2014-07-05 11:34:36+0200 [INFO VOEventSubscriber,client] VOEvent ivo://nasa.gsfc.gcn/SWIFT#XRT_Proc_Spec_603488-809 received from IPv4Address(TCP, '152.78.192.87', 8099)
2014-07-05 11:34:36+0200 [INFO -] Event rejected (Previously seen by this broker); discarding
2014-07-05 11:34:36+0200 [INFO VOEventSubscriber,client] VOEvent ivo://nasa.gsfc.gcn/SWIFT#XRT_Proc_Spec_603488-809 received from IPv4Address(TCP, '50.116.49.68', 8099)
2014-07-05 11:34:36+0200 [INFO -] Event rejected (Previously seen by this broker); discarding
2014-07-05 11:34:36+0200 [INFO VOEventSubscriber,client] VOEvent ivo://nasa.gsfc.gcn/SWIFT#XRT_Proc_Spec_603488-809 received from IPv4Address(TCP, '152.78.192.87', 8099)
2014-07-05 11:34:36+0200 [INFO VOEventSubscriber,client] VOEvent ivo://nasa.gsfc.gcn/SWIFT#XRT_Proc_Spec_603488-809 received from IPv4Address(TCP, '68.169.57.253', 8099)

Here, the same IVORN is received five times. The event comes in both 1.1 and 2.0 formats, so accepting two copies is legitimate. However, two copies are flagged as duplicate, and three are accepted. One must be a mistake.

@jdswinbank jdswinbank self-assigned this Jul 5, 2014

@jdswinbank

This comment has been minimized.

Sign in to view
Owner

jdswinbank commented Jul 5, 2014

This must be due to the way we check events for duplication on receipt, accept them, then handle them, including marking them as received. There's scope for another event to be received and checked before the first has been handled.

@jdswinbank jdswinbank closed this in b850b05 Jul 5, 2014

jdswinbank pushed a commit that referenced this issue Jul 5, 2014

John Swinbank
Combine checking & recording events in the db 
That is, the very act of checking marks an event as having been seen. The
EventRecorder handler is therefore redundant.

Resolves #30.
5afd4ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment