Returning values from .writerow() #33
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Django project, I ran into the (admittedly niche) use case of needing to stream a large CSV file. Django offers a tutorial about how to do this, and it involves creating a fake buffer of sorts to return values from the
csv
writer rather than write to the actual buffer:I have non-ASCII characters in my data and needed to use the
unicodecsv
module and noticed thatunicodecsv
'swriterow()
method did notreturn
anything. Adding areturn
statement fixed my problem. Even if only to better match the native Pythoncsv
module, I think this should be added.Note that
writerows()
still doesn't properly return anything, but it also does not in the native Pythoncsv
module, and so I've left it for consistency's sake.