[GH-62] Fix warnings #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jealous
force-pushed
the
bugfix/removeWarn
branch
from
3a9685a
to
7cd317d
Compare
Fix the warnings in the lib, including: * modify the data in-place * replace `contains` with `contains_exactly` in the test * remove the `MACDH` warning.
jealous
force-pushed
the
bugfix/removeWarn
branch
from
7cd317d
to
056e310
Compare
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 94.93% 94.95% +0.02%
==========================================
Files 3 3
Lines 1046 1051 +5
==========================================
+ Hits 993 998 +5
Misses 53 53
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the warnings in the lib, including:
containswithcontains_exactlyin the testMACDHwarning.