expunge instances before restarting nested transaction #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this call `expunge_all` instead of `expire_all`? I'm seeing some test failures with stale instances that hit https://github.com/sqlalchemy/sqlalchemy/blob/master/lib/sqlalchemy/orm/session.py#L3186 if only `expire_all` is called. At this point unsaved instances can be disregarded I believe?
c0state
commented
Sep 17, 2020
| @@ -56,7 +56,7 @@ def restart_savepoint(session, trans): | |||
| if trans.nested and not trans._parent.nested: | |||
| # ensure that state is expired the way | |||
| # session.commit() at the top level normally does | |||
| session.expire_all() | |||
| session.expunge_all() | |||
There was a problem hiding this comment.
Might want to change above comment if this is accepted
|
@jeancochrane any thoughts on this and #41 ? |
|
Sorry for the extra late reply here @c0state, do you have a sample test I can use to verify the problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this call
expunge_allinstead ofexpire_all?I'm seeing some test failures with stale instances that hit https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_3_19/lib/sqlalchemy/orm/session.py#L2603 if only
expire_allis called.At this point, uncommitted instances can be disregarded I believe?