call make_transient on instance during rehydration if adding fails #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm getting this exception https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_3_19/lib/sqlalchemy/orm/session.py#L2343 in some of my tests where a record is accessed and then deleted. Per the upstream recommendation, this captures that exception and tries calling `make_transient` instead. All other errors are (re-)thrown
|
@jeancochrane thoughts? |
jeancochrane
reviewed
Dec 5, 2020
There was a problem hiding this comment.
Great catch here @c0state, are you able to share a quick test that we might be able to use to verify this change does what we expect?
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
One of my tests in a private repo fails. This PR definitely fixes it, but I'm unsure why at the moment TBH. I think #25 also is similar. The comment about the flask test client causing this matches my experience. It seems removing the add call would work too--unsure where it's used or why it's needed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting this exception https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_3_19/lib/sqlalchemy/orm/session.py#L2343 in some of my tests where a record is accessed and then deleted. Per the upstream recommendation, this captures that exception and tries calling
make_transientinstead.All other errors are (re-)thrown