Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback changes for #22 #29

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Rollback changes for #22 #29

merged 3 commits into from
Nov 23, 2020

Conversation

jeanralphaviles
Copy link
Owner

Addresses #27.

@jeanralphaviles
comment_parser: Add two new test cases. In context of #27.
e88ebb2
@jeanralphaviles
Revert "comment_parser: Fix escaped quote handling in string literals."
3a802b7 
This reverts commit 7048f63 to address #27.
The regex introduced by this commit was computationally expensive and
would cause comment_parser to run indefinitely.
@jeanralphaviles
comment_parser: Bump to version 1.2.3.
bf74afa
@jeanralphaviles jeanralphaviles merged commit bf74afa into master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jeanralphaviles