Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback changes for #22 #29

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Rollback changes for #22 #29

merged 3 commits into from
Nov 23, 2020

Commits on Nov 23, 2020

  1. comment_parser: Add two new test cases. In context of #27.

    @jeanralphaviles
    jeanralphaviles committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e88ebb2 View commit details
    Browse the repository at this point in the history

  2. Revert "comment_parser: Fix escaped quote handling in string literals." 

    This reverts commit 7048f63 to address #27.
The regex introduced by this commit was computationally expensive and
would cause comment_parser to run indefinitely.
    @jeanralphaviles
    jeanralphaviles committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    3a802b7 View commit details
    Browse the repository at this point in the history

  3. comment_parser: Bump to version 1.2.3.

    @jeanralphaviles
    jeanralphaviles committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    bf74afa View commit details
    Browse the repository at this point in the history