Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fromRect Optional (and other improvements) #30

Closed
wants to merge 120 commits into from
Closed

Make fromRect Optional (and other improvements) #30

wants to merge 120 commits into from

Conversation

SteffeyDev
Copy link

@SteffeyDev SteffeyDev commented Jun 1, 2017 •
edited
Loading

This is a usability update with three significant changes:

  • When no fromRect prop is passed in, the popover scales from the middle of the screen, allowing for more use cases. This is very useful when the button that launches the popover is in a scrollview and may be in different positions, and thus calculating a rectangle would be difficult.
  • The content view is given a 10px padding from the edges of the screen in all cases. This makes it more visually evident that the popover is floating in front of the screen.
  • The entire view is now in a modal so that the popover always shows on top (This makes PR Added zIndex to make the popover always display in front of everything #27 not needed, which is better because zIndex is currently unreliable on Android).
  • Tapping on the content view itself no longer dismisses the popover, only tapping on the background view does. This allows for the use of a scrollview and other types of views in the popover that was not previously possible.

I have found these improvements make this component usable and useful on my iPad.
Note: I do not have an Android tablet to test on, so this would be necessary before merging.

@SteffeyDev
Buffer Popover Off Edges
a6e7aa7 
This keeps the popover view from being flush with the edges.
@SteffeyDev
Support for Missing fromRect Prop
09f1ba9 
This simply scales the view from the middle when there is no fromRect
prop to go off of.
@SteffeyDev
Restore to Initial Animation
03f9ff4 
This undoes an odd but unnecessary change I made.
@SteffeyDev
Fixing the Border Radius by enabling overflow="hidden"
891498b
@SteffeyDev SteffeyDev changed the title No Need for fromRect Prop (and other improvements) Make fromRect Optional (and other improvements) Jun 1, 2017
SteffeyDev and others added 9 commits June 1, 2017 16:37
@SteffeyDev
Update README.md
1ad6abb
@SteffeyDev
Update README.md
37492ca
@SteffeyDev
Support for Changing Display Widths
4165932
@SteffeyDev
Switch to New Popover && Flash Fix
b91cfeb 
I copied the popover file from uk-agilityworks and modified it in the
same way as the other, looking for stability fixes.  Turns out, it was
the native driver causing the flickering, so turned that off.  Now
supports Android without crashing.
@SteffeyDev
Update Version Number
ac8d3fa
@SteffeyDev
View now moves to make space for the keyboard
aadcb8c
@SteffeyDev
Update version
3a19211
@SteffeyDev
Reworked auto direction algorithm, prevention from popover going off …
c55dae8 
…screen
@SteffeyDev
Update Version, add needed dependency
478f16e
SteffeyDev and others added 28 commits November 7, 2018 13:57
@SteffeyDev
Update issue templates
fcc18a7
@SteffeyDev
Update issue templates
bdc6a3c
@SteffeyDev
Adding documentation in response to #28 & #23
5f821a6 
This should help clarify a few things that we learned in those issues
@SteffeyDev
Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view
20fdb9f
@SteffeyDev
Potential fix to Issue #21
65bf5b1
@drewvolz
Update fromView prop spelling in readme
930c1b6
@SteffeyDev
Merge pull request #31 from drewvolz/readme-spelling
95f5fff 
Update fromView prop spelling in readme
@SteffeyDev
Fixing spacing and other errors, fixing for tablets in landscape mode
b26ba5e
@SteffeyDev
removing all default display area skips until I can investigate further
117081b
@SteffeyDev
Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view
195580b
@SteffeyDev
bumping version
7120699
@SteffeyDev
Adding better weird situation handling, for when the popover doesn't …
31839c9 
…show for some reason or doesn't close correctly
@SteffeyDev
bumping version
67a2d5e
@lachlanroche
added portrait-upside-down to Modal supportedOrientations
5195071
@SteffeyDev
Merge pull request #35 from lachlanroche/patch-portraitupsidedown
f471116 
added portrait-upside-down to Modal supportedOrientations
@SteffeyDev
Adding more efficient debugging, ability to place popover's inside of…
b82e45e 
… their fromRect if possible'
@SteffeyDev
Merge branch 'master' of github.com:SteffeyDev/react-native-popover-view
79b0ba0
@SteffeyDev
bumping version
f040b8f
@SteffeyDev
Fixing issue when isVisible is made false while the popover is animat…
d90cce5 
…ing in
@SteffeyDev
Removing unused tests, adding dimension change logging for #34
b0dcaee
@SteffeyDev
Bumping version
ffba514
@SteffeyDev
Version 2 release, with new tooltip mode, display area offset for JS …
d2a30ea 
…modals, and new lifecycle props
@SteffeyDev
Fix for android onDismiss
59c187d
@SteffeyDev
Bumping version
640f0c0
@zhigang1992
chore: add typescript definition
9f473f5
@zhigang1992
fix: support none View components
327b8ac
@zhigang1992
Update index.d.ts
a61b19c
@SteffeyDev
Merge pull request #41 from zhigang1992/patch-1
fcf342b 
chore: add typescript definition
@SteffeyDev SteffeyDev closed this Jun 8, 2019
@SteffeyDev
Copy link
Author

Assumed that this repository is dead, now maintaining my own repository: https://github.com/SteffeyDev/react-native-popover-view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SteffeyDev @johannesschirrmeister @hawkrives @drewvolz @lachlanroche @zhigang1992