-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fromRect Optional (and other improvements) #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the popover view from being flush with the edges.
This simply scales the view from the middle when there is no fromRect prop to go off of.
This undoes an odd but unnecessary change I made.
I copied the popover file from uk-agilityworks and modified it in the same way as the other, looking for stability fixes. Turns out, it was the native driver causing the flickering, so turned that off. Now supports Android without crashing.
7a3040b
to
1371f6c
Compare
This should help clarify a few things that we learned in those issues
Update fromView prop spelling in readme
…show for some reason or doesn't close correctly
added portrait-upside-down to Modal supportedOrientations
… their fromRect if possible'
…modals, and new lifecycle props
chore: add typescript definition
Assumed that this repository is dead, now maintaining my own repository: https://github.com/SteffeyDev/react-native-popover-view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a usability update with three significant changes:
I have found these improvements make this component usable and useful on my iPad.
Note: I do not have an Android tablet to test on, so this would be necessary before merging.