Add keyboard shortcuts for various actions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi there @jeansaad , love Chalet!! I've had a few ideas for improvements since I use it pretty much every day – this will be the first of a couple PRs, as long as you're open to some ideas! the first is this simple change – it's common that i miss the toggle button to turn on or off a monitor, and i click the monitor again, which unselects it and prevents me from viewing any output. i'm not sure that there's much value in not viewing any monitor, which is exactly what happens when you unselect a monitor. thanks so much!
jeansaad
reviewed
Oct 26, 2021
|
I think this makes a ton of sense – I'll add this! |
|
Don't worry about getting too fancy. I'm toying with the idea of a UI overhaul at some point. |
|
Updated! Screen.Recording.2021-10-28.at.11.09.18.AM.mov |
|
This is great so far. Had a look at the recording and the code. Will do a local test first before approving and merging. If you're up for it I'm thinking we should also change the hover over a monitor to something that doesn't conflict with the selected colour. Let me know what you think. If you don't have time, I can quickly do this and merge them all together and make a release. Lmk! Update: Already fixed the li hover issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces keyboard shortcuts for various actions: