Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a new preset is cumbersome/buggy #316

Closed
Column01 opened this issue May 17, 2024 · 4 comments · Fixed by #318
Closed

Making a new preset is cumbersome/buggy #316

Column01 opened this issue May 17, 2024 · 4 comments · Fixed by #318
Labels

Comments

@Column01
Copy link

Thanks for taking the time to submit a bug report! Please include the following information:

What operating system are you using?
Windows 10 22H2 19045.4412

What version of Videomass are you using and how did you install or run it?
5.0.13 installed via pypi

Describe the bug
When creating a preset for converting videos, it opens a file picker dialogue when you click "Save Preset" but this opened file picker is not a "Create a new file" dialogue, it's a "choose an existing file" dialogue. This means that if you want to save your preset you need to manually create a file, rename it to have the .prst extension and then click the button to open that new file. This is silly and cumbersome. On top of that, when I did fill in the info in the newly created file using the popup window (name and description), clicking "Ok" did nothing

@jeanslack
Copy link
Owner

jeanslack commented May 18, 2024

When creating a preset for converting videos, it opens a file picker dialogue when you click "Save Preset" but this opened file picker is not a "Create a new file" dialogue, it's a "choose an existing file" dialogue.

It's an old implementation that involves saving the profile on an existing preset and not creating a new file. I'm planning to replace it it with a choice dialog with the following options:

  • save the profile to an existing preset
  • save the profile to a new preset

This means that if you want to save your preset you need to manually create a file, rename it to have the .prst extension and then click the button to open that new file. This is silly and cumbersome.

No, you don't have to create anything manually. If you want to create a pre-formatted blank preset go to Presets Manager and create it from there.
Moreover, as of Videomass version 5.0.6, the current extension/format for presets is .json now not .prst.

On top of that, when I did fill in the info in the newly created file using the popup window (name and description), clicking "Ok" did nothing

What do you mean nothing happens? Does the "Successful storing" message not appear after saving the profile on the popup window (name and description) ?

@jeanslack
Copy link
Owner

closed due to inactivity

@Column01
Copy link
Author

Column01 commented May 21, 2024

What do you mean nothing happens? Does the "Successful storing" message not appear after saving the profile on the popup window (name and description) ?

When you click OK, literally as I said, nothing happens. The window remains open, no message is displayed and it just remains as it was. It was also a holiday weekend in my country so sorry for not getting back to you

@jeanslack
Copy link
Owner

Don't worry, I have already fixed the bugs you reported, see #318

The preset you created manually probably had errors. This is why you shouldn't create presets manually if you don't know how they should be coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants