-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
segfault due to inifinite loop in hmac branch #55
Comments
Yep. I’ll look into that :) |
Don’t call `start_message()` since it may cause an infinite loop. Closes jech#55.
Don’t call `start_message()` since it may cause an infinite loop. Closes jech#55.
Patch looks good to me. Please add an explicit check in the function that there is enough buffer space, and I'll cherry pick it. |
Patch modified and simplified here f32bf63. |
Hello what is the status regarding this issue ? We are waiting for the fix to deploy HMAC in our network. |
Hello Thomas, The patch is now eb11023 (because of rebases). Regarding the MAC status, you can find updated code in my MAC authentication for the Babel routing protocol PR. It (currently) rebases the hmac branch against 1.9.2, cleans up the code, and add various fixes. The configuration language is also changed ( |
This is now commit af02039, and has been merged into master. |
we are using babeld on
hmac
branch with the following options-C key type blake2s id sign value XXXXXXXXXXXXXXXXX -C default hmac sign no_hmac_verify true
. From time to time, we see babeld crashing with a segfault.We managed to have a coredump file, and the problem is
flushbuf
(called from main function) callssend_crypto_seqno
which callsstart_message
which in turn callsflushbuf
in a infinite loop.Here are the information from gdb:
The exact source code used include patches from Nexedi and can be found here : https://lab.nexedi.com/nexedi/babeld/tree/hmac-nxd2
The text was updated successfully, but these errors were encountered: