Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Pass state param to GitHub. Some other minor GitHub fixes #59

Merged
merged 1 commit into from
Jan 8, 2014

Conversation

aslakhellesoy
Copy link
Contributor

  • No scope default (using [] seemed wrong since it's a string)
  • Fix GitHub case
  • Fixed create app link

Closes #50

* No scope default (using [] seemed wrong since it's a string)
* Fix GitHub case
* Fixed create app link
jed added a commit that referenced this pull request Jan 8, 2014
Pass state param to GitHub. Some other minor GitHub fixes
@jed jed merged commit 74f1d2f into jed:master Jan 8, 2014
@jed
Copy link
Owner

jed commented Jan 8, 2014

thanks! i hope you don't mind, but i've made you a collaborator so you can land these faster.

@aslakhellesoy
Copy link
Contributor Author

Much appreciated @jed

Would you let me cut releases as well? I don't expect to be super active, just want to help out taking some load off when I can.

@jed
Copy link
Owner

jed commented Jan 8, 2014

sure! what is your NPM username?

On Wednesday, January 8, 2014, Aslak Hellesøy wrote:

Much appreciated @jed https://github.com/jed

Would you let me cut releases as well? I don't expect to be super active,
just want to help out taking some load off when I can.


Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-31864792
.

@aslakhellesoy
Copy link
Contributor Author

aslakhellesoy - aslak.hellesoy@gmail.com

Thanks buddy

On Wednesday, 8 January 2014 at 19:03, Jed Schmidt wrote:

sure! what is your NPM username?

On Wednesday, January 8, 2014, Aslak Hellesøy wrote:

Much appreciated @jed https://github.com/jed

Would you let me cut releases as well? I don't expect to be super active,
just want to help out taking some load off when I can.


Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-31864792
.


Reply to this email directly or view it on GitHub (#59 (comment)).

@jed
Copy link
Owner

jed commented Jan 8, 2014

cool, done!

On Wed, Jan 8, 2014 at 2:13 PM, Aslak Hellesøy notifications@github.comwrote:

aslakhellesoy - aslak.hellesoy@gmail.com

Thanks buddy

On Wednesday, 8 January 2014 at 19:03, Jed Schmidt wrote:

sure! what is your NPM username?

On Wednesday, January 8, 2014, Aslak Hellesøy wrote:

Much appreciated @jed https://github.com/jed

Would you let me cut releases as well? I don't expect to be super
active,
just want to help out taking some load off when I can.


Reply to this email directly or view it on GitHub<
https://github.com/jed/authom/pull/59#issuecomment-31864792>
.


Reply to this email directly or view it on GitHub (
#59 (comment)).


Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-31867283
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass state param to Github
2 participants