Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not finding reveal template's fonts #45

Closed
kbrock opened this issue May 24, 2015 · 1 comment · Fixed by #47
Closed

Not finding reveal template's fonts #45

kbrock opened this issue May 24, 2015 · 1 comment · Fixed by #47

Comments

@kbrock
Copy link
Contributor

kbrock commented May 24, 2015

I'm getting the following errors in my browser:

GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-regular.woff
GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-italic.woff
GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-semibold.woff
GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-regular.ttf 
GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-italic.ttf 
GET http://localhost:3000/lib/font/source-sans-pro/source-sans-pro-semibold.ttf 

Get this error when serving or generating
note: Gemfile with a relative path element.

Seems the files are present:

reveal-ck $ git submodule init ; git submodule update
reveal-ck $ find . -name \*source-sans-pro\* -type f
./files/reveal.js/lib/font/source-sans-pro/source-sans-pro-italic.eot
./files/reveal.js/lib/font/source-sans-pro/source-sans-pro-italic.ttf
./files/reveal.js/lib/font/source-sans-pro/source-sans-pro-italic.woff
...
./files/reveal.js/lib/font/source-sans-pro/source-sans-pro.css

Is this an issue or is this just backwards compatibility?
(I don't need this to work in anything other than the latest. And it still looks good.)
Also, I'm probably not going to create a style any time soon

When generating I have the following:

12factor $ find . -name \*source-sans-pro\* -type f
./12factor/lib/font/source-sans-pro/source-sans-pro.css
@jedcn
Copy link
Owner

jedcn commented May 25, 2015

I'm seeing the same thing:

missing-font-files

I suspect these aren't copied "into" the presentation because I only see this single file in the generated presentation: slides/lib/font/source-sans-pro/source-sans-pro.css.

There's a ruby file that represents the manifest of files that should be copied "into" the presentation from reveal.js.

I'd guess it needs to be modified-- I'll take a look shortly. The line in question is right here, and it should probably be changed to include these font files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants