support kvm provider

[miurahr]

support KVM provider

I need to rename Libvirt as ProviderLibvirt to name congestion,
because ruby-libvirt has Libvirt namespace.

Signed-off-by: Hiroshi Miura miurahr@linux.com

[jedi4ever]

@miurahr we can't automerge, could you rebase?

[miurahr]

rebased.

[jedi4ever]

thx @miurahr , if some-one else can confirm and test this.

[miurahr]

Any progress?

[aspiers]

This PR doesn't make sense to me:

1. There is no namespace conflict because ruby-libvirt uses ::Libvirt which is different from Sahara::Session::Libvirt.
2. It adds lib/sahara/session/kvm.rb which does not contain KVM-specific code, only libvirt code.

What am I missing?

[aspiers]

1. It adds lib/sahara/session/kvm.rb which does not contain KVM-specific code, only libvirt code.

What am I missing?

Oh I see, I was missing that this is adding support for vagrant-kvm, which just like vagrant-libvirt, uses libvirt as the backend. However my first question about the (lack of) namespace conflict still stands.

Also it doesn't seem good that this is mostly a copy'n'paste from lib/sahara/session/libvirt.rb - surely it could inherit from Sahara::Session::ProviderLibvirt and then override the necessary bits?