progress: fix race-condition while reading value

jedib0t · Jun 10, 2019 · 216d1ef · 216d1ef
1 parent f5c9bfa
commit 216d1ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/progress/progress.go b/progress/progress.go
@@ -79,9 +79,11 @@ func (p *Progress) AppendTracker(t *Tracker) {
 	p.trackersInQueueMutex.Lock()
 	p.trackersInQueue = append(p.trackersInQueue, t)
 	p.trackersInQueueMutex.Unlock()
+	p.overallTracker.mutex.Lock()
 	if p.overallTracker.Total < int64(p.Length())*100 {
 		p.overallTracker.Total = int64(p.Length()) * 100
 	}
+	p.overallTracker.mutex.Unlock()
 	p.overallTrackerMutex.Unlock()
 }
 

diff --git a/progress/render.go b/progress/render.go
@@ -244,7 +244,9 @@ func (p *Progress) renderTrackerStats(out *strings.Builder, t *Tracker, hint ren
 		var outStats strings.Builder
 		outStats.WriteString(" [")
 		if !hint.hideValue {
+			t.mutex.Lock()
 			outStats.WriteString(p.style.Colors.Value.Sprint(t.Units.Sprint(t.value)))
+			t.mutex.Unlock()
 		}
 		if !hint.hideValue && !hint.hideTime {
 			outStats.WriteString(" in ")