Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress speed #224

Merged
merged 1 commit into from
Sep 3, 2022
Merged

feat: progress speed #224

merged 1 commit into from
Sep 3, 2022

Conversation

iyear
Copy link
Contributor

@iyear iyear commented Sep 3, 2022

Proposed Changes

  • add progress speed render
  • modify render_test.go
  • modify demo and demo.gif

@coveralls
Copy link

coveralls commented Sep 3, 2022

Pull Request Test Coverage Report for Build 2983379914

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2901119745: 0.0%
Covered Lines: 3134
Relevant Lines: 3134

💛 - Coveralls

@iyear
Copy link
Contributor Author

iyear commented Sep 3, 2022

I will add some tests later

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jedib0t jedib0t merged commit ab70b68 into jedib0t:main Sep 3, 2022
@jedib0t
Copy link
Owner

jedib0t commented Sep 3, 2022

Thanks for the feature, and the extra effort to keep the coverage at 100%. I'll merge it, but I want to add some stuff on top. Will cut a tag later today. 👍🏽

@jedib0t
Copy link
Owner

jedib0t commented Sep 3, 2022

@iyear I've made some changes on top of your feature code, most important of which is to change the default options to NOT show speed to maintain backward compatibility. Please look at #225 for the same.

Tag for use: https://github.com/jedib0t/go-pretty/releases/tag/v6.3.8

@iyear
Copy link
Contributor Author

iyear commented Sep 4, 2022

I wasn't thinking about backward compatibility, thanks!

@iyear iyear deleted the feat-progress-speed branch September 4, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants