Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress: more options for speed, and backward-compatible defaults #225

Merged
merged 3 commits into from
Sep 3, 2022
Merged

progress: more options for speed, and backward-compatible defaults #225

merged 3 commits into from
Sep 3, 2022

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented Sep 3, 2022 •
edited
Loading

Proposed Changes

  • change the defaults for new options introduced in feat: progress speed #224 to be backward compatible
  • use the Tracker Units formatter when rendering speed for a Tracker
  • provide option to control position of "speed"
  • fix unit-tests

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2985668820

  • 43 of 43 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2985413107: 0.0%
Covered Lines: 3141
Relevant Lines: 3141
💛 - Coveralls

@jedib0t jedib0t merged commit fb89930 into main Sep 3, 2022
@jedib0t jedib0t deleted the progress-speed branch September 3, 2022 20:23
@jedib0t jedib0t mentioned this pull request Sep 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jedib0t @coveralls