Add a exemple macro for source highlight as described in #17. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just updated the pull request to take into account your comments. |
|
Any new comments? |
|
A unittest would be good. pygments must be added to https://github.com/jedie/python-creole/blob/master/.travis.yml for test. Maybe i will also look at this tomorrow. |
|
Is my unittest enough? |
jedie
added a commit
that referenced
this pull request
May 15, 2014
Add a exemple macro for source highlight as described in #17.
|
Looks good! Thanks. |
|
Thanks for merging and improving my code and the unittests |
|
commit one missing thing: escaping if fallback used: ff3962b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.