Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnscrypt-proxy doesn't kill its child process if the main process is stopped #547

Closed
konimex opened this issue Jul 16, 2018 · 4 comments
Closed
Labels
help wanted Extra attention is needed linux

Comments

@konimex
Copy link

konimex commented Jul 16, 2018

Description

When the main dnscrypt-proxy program/service (root) is stopped, the child process is still running. This means if I restart the dnscrypt-proxy service, it would fail since there's already a dnscrypt-proxy instance running.

Expected

The child process is also killed along with its parent process.

Actual result

The child process still runs under init.

2018-07-16-185505_1490x363_scrot

I'm not sure if this is intended or a bug. But I'm leaning towards the latter.

@jedisct1
Copy link
Member

What operating system is that on? How are you stopping it? Using dnscrypt-proxy -service stop?

@konimex
Copy link
Author

konimex commented Jul 16, 2018

Artix Linux, using runit as init system. (Also testing on Void Linux to see if this problem only exists on Artix or also happens on Void)Also happened on Void.

I stopped it using sv stop dnscrypt-proxy command provided by runit.

@jedisct1
Copy link
Member

Do you know how to fix this?

@konimex
Copy link
Author

konimex commented Jul 17, 2018

I think when the main process caught SIGTERM from the service manager (in this case, runit), kill its child process (if any). However I'm not sure if the main process tracks its child, and I'm not well-versed in Go.

@jedisct1 jedisct1 added help wanted Extra attention is needed linux labels Jul 17, 2018
@DNSCrypt DNSCrypt locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed linux
Projects
None yet
Development

No branches or pull requests

2 participants