Make sure config.sub and config.guess are executable #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Spack build on ppc64 and aarch64, see spack/spack#21256
|
Hi, The fact that they need to be executable is a little bit surprising. The $SHELL "$ac_aux_dir/config.guess"$SHELL "$ac_aux_dir/config.sub"If the |
jedisct1
added a commit
that referenced
this pull request
Jan 27, 2021
* Make sure config.sub and config.guess are executable This fixes Spack build on ppc64 and aarch64, see spack/spack#21256 * Move config files after setting their mode Co-authored-by: Frank Denis <124872+jedisct1@users.noreply.github.com>
jedisct1
added a commit
that referenced
this pull request
Jan 27, 2021
* Make sure config.sub and config.guess are executable This fixes Spack build on ppc64 and aarch64, see spack/spack#21256 * Move config files after setting their mode Co-authored-by: Frank Denis <124872+jedisct1@users.noreply.github.com>
|
Yes, I expect it would work for a normal build. However, Spack has an autotools workaround where it tries to manually execute these scripts to check if they work (I have no idea what was the original issue that required this workaround). It's applied to all autotools-based packages, not just libsodium. By the way, the upstream scripts are executable: https://git.savannah.gnu.org/gitweb/?p=config.git;a=tree |
Repository owner
locked and limited conversation to collaborators
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Spack build on ppc64 and aarch64, see spack/spack#21256