Delete critical section on DLL_PROCESS_DETACH #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To explicitly release all allocated resources on shutdown on Windows, we delete the critical section on `DLL_PROCESS_DETACH`. We do not employ any locking to avoid any potential deadlock. In case of normal DLL unloading there is no need to, and in case of forced unloading all bets are likely off anyway.
Closed
|
Thank you! |
Repository owner
locked and limited conversation to collaborators
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To explicitly release all allocated resources on shutdown on Windows,
we delete the critical section on
DLL_PROCESS_DETACH. We do notemploy any locking to avoid any potential deadlock. In case of normal
DLL unloading there is no need to, and in case of forced unloading all
bets are likely off anyway.