[dotnet core] build for linux-musl-arm64 #1174
Conversation
|
Nice work 😃 The artifact (libsodium.so) also needs to be added to libsodium.pkgproj so it gets included in the NuGet package. |
|
Done - I think! |
|
libsodium.pkgproj looks good to me. While you're at it, you could also increment the version number in the same file. Now someone needs to go ahead and test if the NuGet package actually works on their musl arm64 machine 😊 |
|
@ektrah That can be tested in a docker container. I might have some time later this week to build a proper test script for it. |
Happy to bump the version - to 1.0.19.0? |
That would be 1.0.18.3 (the third revision of the NuGet package containing pre-compiled binaries of libsodium 1.0.18). |
|
@SeanMollet I'm happy to help with writing test scripts - I presume I need to build the package locally to test it? The CI process doesn't appear to publish it anywhere as far as I can tell. |
jedisct1
changed the title
|
Is there anything more I can do to help get this finalised and merged? |
|
Could |
|
@MichalPetryka, .NET doesn’t run on s390x. (Note that this particular PR is about the packaging of libsodium for .NET, not libsodium in general.) |
It does with community builds, fedora package repository does provide s390x builds of it. |
|
I'd be happy to do what I did for arm64 to add an arm build - would the maintainers prefer another PR for that? The issue now is testing though, which I'm happy to help with if I can, and if someone wants to give me a steer. |
* Adding aarch64 build * Removing workflow_dispatch * Re-adding x64 * Disable libgcrypt hash - #1173 * Adding sudo to gcrypt disable - #1173 * Remove sudo, put gcrypt disable before building source list - #1173 * Adding linux-musl-arm64 build to NuGet package - #1174 * Explain the gcrypt configuration hack
See #1173