Prevent segfault with some binary characters. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My C isn't good enough to know the "why" of this, but it seems to fix the issue we were seeing in #9... |
e.g. "\xE9". Fixes: ``` multi_string_replace/spec/multi_string_replace_spec.rb:131: [BUG] Segmentation fault at 0x0000000000000000 ruby 3.0.6p216 (2023-03-30 revision 23a532679b) [x86_64-linux] -- Control frame information ----------------------------------------------- c:0031 p:---- s:0157 e:000156 CFUNC :replace c:0030 p:0021 s:0151 e:000149 BLOCK /mnt/limepoint/multi_string_replace/spec/multi_string_replace_spec.rb:131 [FINISH] c:0029 p:---- s:0147 e:000146 CFUNC :instance_exec ... ``` Upstream has this as an `unsigned char`, hence the use of it: https://github.com/morenice/ahocorasick/blob/1914054f60e7d92ac0f0b5ae95dfd36fb00e9b6b/src/aho_trie.c#L32
jedld
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. "\xE9".
Fixes:
Fixes: #9