Merge pull request #23 from AlbertoGP/spawn-with-shell

Use spawn with a shell to get best of both worlds

lib/rsyncwrapper.js

@@ -1,7 +1,6 @@
 "use strict";
 
 var spawn = require("child_process").spawn;
-var exec = require("child_process").exec;
 var util = require("util");
 var _ = require("lodash");
 
@@ -111,7 +110,16 @@ exports.rsync = function (options,callback) {
 
         var stdout = "";
         var stderr = "";
-        var child = exec(cmd,{maxBuffer:1000*1024},noop);
+        // Launch cmd in a shell just like Node's child_process.exec() does:
+        // see https://github.com/joyent/node/blob/937e2e351b2450cf1e9c4d8b3e1a4e2a2def58bb/lib/child_process.js#L589
+        var child;
+        if ('win32' === process.platform) {
+            child = spawn('cmd.exe', ['/s', '/c', '"' + cmd + '"'],
+                          {windowsVerbatimArguments:true} );
+        }
+        else {
+            child = spawn('/bin/sh', ['-c', cmd]);
+        }
 
         child.stdout.on("data",function (data) {
             onStdout(data);