Fix names in simp config answers file, clean up #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the server hostname in the `simp config` answers file. It also cleans up the file for readability and renames it using a more verbose, obvious name.
| @@ -5,7 +5,7 @@ Vagrant.configure('2') do |c| | |||
| server_post_up = <<-EOS.gsub(/^[[:blank:]]{4}/, '') | |||
| Now run the following commands to get going: | |||
|
|
|||
| simp config -a /vagrant/answers.yaml | |||
| simp config -a /vagrant/simp_config_answers.yaml | |||
There was a problem hiding this comment.
This was originally just the simp config answers file, taken from /root/.simp/simp_conf.yaml. All of the syntax stuff was what was outputted by simp config.
There was a problem hiding this comment.
Yeah, I saw that in the header. If it's all the same, though, I think using something like this is better for distribution. My goal here was to make it easier to read and understand, because this will be used for training and probably by users wanting to try out SIMP without too much work.
There was a problem hiding this comment.
Alright but this provided file will be different than what a user might get when they look in their generated simp_conf.yaml.
|
Do you get notified for file comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the server hostname in the
simp configanswers file. Italso cleans up the file for readability and renames it using a more
verbose, obvious name.