Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(convert): ClassVar was ignored by Pydantic #292

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix(convert): ClassVar was ignored by Pydantic #292

merged 2 commits into from
Oct 19, 2023

Conversation

jeertmans
Copy link
Owner

Using default factory function instead.

Using default factory function instead.
@jeertmans jeertmans added bug Something isn't working html-convert Related to converting to HTML slides labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Files Coverage Δ
manim_slides/__init__.py 60.00% <100.00%> (ø)
manim_slides/__main__.py 71.42% <100.00%> (-0.67%) ⬇️
manim_slides/commons.py 96.15% <ø> (ø)
manim_slides/config.py 84.13% <100.00%> (+0.22%) ⬆️
manim_slides/logger.py 100.00% <100.00%> (ø)
manim_slides/present/player.py 76.62% <100.00%> (ø)
manim_slides/slide/manimlib.py 100.00% <100.00%> (ø)
manim_slides/slide/animation.py 97.56% <97.56%> (ø)
manim_slides/utils.py 89.74% <83.33%> (-2.15%) ⬇️
manim_slides/convert.py 87.60% <66.66%> (+13.41%) ⬆️
... and 6 more

📢 Thoughts on this report? Let us know!.

@jeertmans jeertmans merged commit f3dfa78 into main Oct 19, 2023
15 of 16 checks passed
@jeertmans jeertmans deleted the fix-convert branch October 19, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html-convert Related to converting to HTML slides
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant