Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite vanished from download tarball #122

Open
tillea opened this issue Oct 8, 2019 · 4 comments
Open

Test suite vanished from download tarball #122

tillea opened this issue Oct 8, 2019 · 4 comments

Comments

@tillea
Copy link

tillea commented Oct 8, 2019

Hi,
when I tried to rebuild the Debian package of DendroPy I was pointed to the fact that the test suite code was removed from the archive. So

$ python3 setup.py test

simply fails since there is only data but no code to run the test suite. It would be great if you could provide some test code - most preferably code that does not depend from PAUP which we can not use in Debian since it is non-free.
To at least do some testing at all I'm now using

sumtrees.py --summary-target consensus \
         --min-clade-freq=0.95 \
         --edges mean-length \
         --burnin=200 \
         --support-as-labels \
         --output=pythonidae_result.tre \
         pythonidae.mlboots.newick.tre  pythonidae.random.bd0301.midpoint-rooted.tre  pythonidae.random.bd0301.tre

as a continuous integration test. Better ideas are more than welcome, Andreas.

@jeetsukumaran
Copy link
Owner

I cannot speak for or to the Debian packaging of DendroPy. I have no idea what the state of or changes have been made to DendroPy in the Debian package.

I had previously communicated with Andreas Tille (tille@debian.org) who contacted me regarding the licensing of some of the content of the full DendroPy package. He wanted to make sure that all content was available under an Open Source license. I indicated that while all code was, the test data was not. And could not --- data cannot be copyrighted or licensed as far as I know. I never heard back from him.

The full DendroPy package, as available from its primary source code repos, and as maintained by ourselves, do indeed include the test data:

https://github.com/jeetsukumaran/DendroPy/tree/master/tests/data

@jeetsukumaran
Copy link
Owner

Ah, looking at the emails, it might be possible that tille@debian.org is, in fact, yourself?

@jeetsukumaran
Copy link
Owner

And I see now that the issue is with test code itself and not the data?

@tillea
Copy link
Author

tillea commented Oct 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants