Add support for TB 68.0 #88

jeevatkm · 2019-09-02T20:14:50Z

The goal of this issue to identify the necessary updates required for RWH to make it work in TB 68.0

Please Note: I have to learn and perform this upgrade, it might take a while due to my day work commitments. However, I will surely add support 😄

jeevatkm · 2019-09-02T20:36:07Z

Collected notes:

wikiaal · 2019-09-17T07:06:22Z

Please, give support. I had to go back to TB 60.9.0 because your add-on doesn't work with TB 68.0.

WesleyGeneroso95 · 2019-09-19T09:58:45Z

+1
Please, give support to the TB 68.0.

FxRe · 2019-09-19T13:30:38Z

People, he already announced that he's working on it. I don't think it'll go any faster, if you just reply "Please, give support"... If you want it so badly, you'll have to be more productive.

wikiaal · 2019-09-21T04:36:46Z

People, he already announced that he's working on it. I don't think it'll go any faster, if you just reply "Please, give support"... If you want it so badly, you'll have to be more productive.

Thunderbird 68 had been published in beta for 2 months ... maybe think about it a little earlier ...

FxRe · 2019-09-21T12:22:40Z

Thunderbird 68 had been published in beta for 2 months ... maybe think about it a little earlier...

Even if it had been published 2 decades ago, that doesn't make a difference at all right now.

jeevatkm · 2019-09-23T19:03:54Z

@FxRe Thank you for your understanding and support.

@wikiaal Thanks for sharing your concerns. From RWH user standpoint, it's very valid.

I want to share my situation and perspective. I love doing open-source projects and do my best with my limited time along with day work, family, personal, etc. So, I wait until the final version comes out. Then I search for documentation for changes needs to performed, sometimes due to unavailable documentation; I have to take an additional step to learn from fellow add-on developers by reverse engineering.

Spicy on Top: The past couple of years TB has been releasing quite no. of breaking changes and its good for TB roadmap but it brings challenges to add-on developers. Also, TB has very very limited documentation in these scenarios.

I kindly request you to recognize that fact and provide support.

wikiaal · 2019-09-24T05:26:26Z

If you need someone to make tests with upcoming RWH for TB v68 please ask.

insekt · 2019-10-09T06:10:31Z

Please add support for Thunderbird 68. I'm in 1 step from switching to Outlook =(

dpate71 · 2019-10-12T08:23:19Z

Any news on RWH compatibility for TB 68?

athanas55 · 2019-10-14T07:52:22Z

Please add support for Thunderbird 68. I'm in 1 step from switching to Outlook =(

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

insekt · 2019-10-14T08:15:32Z

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

jeevatkm · 2019-10-15T06:34:27Z

Hello All -

I have created a working version RWH v2.2.0-beta addon for TB 68 plus version. However, there is an issue yet be sorted out is RWH preferences (no errors, needs investigation).

Download link: http://bit.ly/2MFswW5

In the meantime, can you please try and share your feedback.

Cheers, Jeeva

wikiaal · 2019-10-15T07:00:23Z

Dear Jeeva, thank you very much for your work!!! I've just upgraded (in my secondary laptop) to TB 68.1.2 and installed RWH 2.2 beta. I'll send you a feedback a.s.a.p.

jeevatkm · 2019-10-15T07:03:02Z

@wikiaal Thank you for your help, appreciated 👍

wikiaal · 2019-10-15T09:44:11Z

Dear Jeeva,
first test with TB 68.1.2: the RWH 2.2.beta seems to work properly for mail reply and forward, but I have no access to RWH settings (I see only deactivate and remove buttons, no settings button anywhere).

insekt · 2019-10-15T10:21:44Z

@jeevatkm thank you very much!
@wikiaal confirm the same behaviour.

zdenekvecera · 2019-10-15T10:35:10Z

@jeevatkm, thank you very much!

ghost · 2019-10-15T10:40:44Z

WFM with 70.0b3 (64-bit) on WIN 10 Pro v1903 x_64, except no settings to access.

Just thought to mention about the display of settings:

This MX (mail extension) https://mailredirect.sourceforge.io for example integrates its settings with the main Options -> Composition UI

Whilst this one https://github.com/lieser/dkim_verifier features its own tab

WesleyGeneroso95 · 2019-10-15T11:32:18Z

Dear Jeeva,
I'm testing the plugin with TB 68.1.2 and everythings seems to work great.

athanas55 · 2019-10-15T12:15:18Z

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

@insekt Try searching for SmartTemplate4

wikiaal · 2019-10-15T12:50:38Z

Maybe you should, if you think 5 dollars for the other plugin that does the same job (and a bit more) doesn't worth it.

@athanas55 Could you point me to that plugin?

@insekt Try searching for SmartTemplate4

SmartTemplate4 is more complex (and less reliable) to use than RWH and isn't free.

m-i-k-e-y · 2019-10-15T17:17:54Z

@jeevatkm: The beta you provided is working for me. Thank you!

This is the only thing I've found in the error console related to this extension:

1571159586588 addons.webextension.replywithheader@myjeeva.com WARN Loading extension 'replywithheader@myjeeva.com': Reading manifest: Error processing xpi-name: An unexpected property was found in the WebExtension manifest.

alphp · 2019-10-15T17:36:39Z

@jeevatkm thank you very much!
@wikiaal confirm the same behaviour.

jeevatkm · 2019-10-17T06:49:06Z

Thank you @wikiaal, @zdenekvecera, @insekt, @WesleyGeneroso95, @m-i-k-e-y, @alphp for trying out and sharing your feedback.

Once I sort out the implementation of the RWH settings, I will make a few more beta releases to ensure everything works then I will do a final release.

I want to provide internal details of TB and its roadmap. How it's affecting the addons.

Since TB 68 addon model is changed to WebExtension/MailExtension. all the changes I'm doing will be good until version TB 78. So a permanent solution is to rewrite the RWH addon into the WebExtension model. I will learn and do it later on.

jeevatkm · 2019-10-20T04:49:57Z

Hello All -

I have prepared the next beta version with RWH preferences issues fixed. Can you please test it out and provide your feedback?

Download link: http://bit.ly/2BtWMOx

I will wait for couple of weeks, If everything working alright then I will bump the release version to v3.0.0 and I will submit it to AMO.

Cheers, Jeeva

wikiaal · 2019-10-20T05:28:56Z

Hi Jeeva,
first of all thank you very much for the work done!!!

Just tested the new RWH v2.2.1-beta with a clean Thunderbird 68.1.2 installation:

Good and identical results in Reply and Forward (both functions seem to work well).
I would just like to make a remark: the Reply/Forward headings use a (forced) font (Thaoma) other than the default one that is set in Thunderbird as (Latin) Sans Serifs (Calibri); in other words, the header font does not fit with the format of the body.
Still cannot find "Settings" button anywhere.

With my best regards
Andrea

jeevatkm · 2019-10-20T05:37:21Z

Hello Andrea -
Thank you for your feedback.

I will work on default font once I address the TB 68+ support also there is an enhancement/bug request needs to be done too
TB moved that to
- For windows/linux "Tools -> Addon Options -> RWH Preferences"
- For mac "Tools -> Addon Preferences -> RWH Preferences" - (Please note: It seems TB has some bug, sometimes it does not show up the options for me)

Cheers, Jeeva

zdenekvecera · 2019-10-20T08:11:33Z

@jeevatkm, thank you very much.

I couldn't change my settings in a previous beta. But in this new RWH v2.2.1-beta the settings works again. Great!

m-i-k-e-y · 2019-10-20T08:44:04Z

@jeevatkm Thanks again. Settings do open for me and seem to work so far.

The error message I've seen with the previous beta is gone too in the error console, only this warning is left:

Ignoring unrecognized chrome manifest directive 'overlay'. chrome.manifest:16

That points to this line in the manifest of your addon:

overlay chrome://messenger/content/messengercompose/messengercompose.xul chrome://replywithheader/content/messengerComposeOverlay.xul

Keep up the good work!

wikiaal · 2019-10-20T09:25:46Z

Okay, I've found RWH "Settings": Tools > Addon Options > ReplyWithHeader.

Thank you very much!!!
Andrea

tidebre67 · 2019-10-20T09:26:29Z

Jeeva,
as far as i can see RWH v2.2.1-beta works really fine.

many tks

ghost · 2019-10-20T09:43:49Z

Hi Jeeva,

reply and forward work properly. Preferences are not being displayed under Tools>Add-on Preferences. Tried it a couple of times. I won´t give up! ;)

EDIT: Got the preferences! I searched in the wrong place!

Thank you very much for your work!

wikiaal · 2019-10-20T09:48:36Z

Hi Jeeva,
after some more tests, I've found an issue with RWH: replying to some mails, with "Forward" I have the original body with the same format of the header (body text, font), with "Reply" the body format becomes different (preformatted?) with plain fixed lenght font, while the header remains as with "Forward".

athanas55 · 2019-10-24T07:18:01Z

Hello Jeeva
Just installed the beta and its performing as it should until now.
System: W10, 64bit, v.1903,
TB: 68.2.0, 64bit.
In case any bugs come up I'll report them here.
Thank you for your efforts and dedication to open-source projects.

Thanos

jc97 · 2019-12-27T12:55:32Z

Hello,

I tried the beta version too and it is working perfectly for me. I think you can bump the release.

Thanks!

netjeff · 2020-01-25T05:10:03Z

Just found this thread. Installed the beta, and works perfectly. Looking forward to the official release. Thanks @jeevatkm! I just donated, hopefully lots of people will donate for your great work.

jeevatkm · 2020-03-02T20:15:40Z

Dear All - FYI, RWH v2.2.1 release version submitted to AMO for approval.

wikiaal · 2020-03-03T06:20:53Z

Hi Jeeva,
thank you so much for your invaluable work, look forward for final 2.2.1 version of RWH.

With my best regards
Andrea

jeevatkm · 2021-09-12T05:19:21Z

Hello @wikiaal - I'm wondering. is these are your reviews? if yes, do you mind updating the review and stars?

https://addons.thunderbird.net/en-US/thunderbird/addon/replywithheader/reviews/user:13652970

Regards,
Jeeva

jeevatkm self-assigned this Sep 2, 2019

jeevatkm added new feature Between TB 60 and 67 labels Sep 2, 2019

jeevatkm added this to the v3.0.0 Release milestone Sep 2, 2019

This was referenced Sep 2, 2019

incompatible with TB69 (beta) #86

Closed

Thunderbird 64.0b1 states addon incompatible even though install.rdf looks OK #70

Closed

jeevatkm mentioned this issue Sep 7, 2019

[solved] language / region customizations #90

Closed

jeevatkm added a commit that referenced this issue Oct 15, 2019

#88 adding support for tb68 plus still prefs needs to sort out

b928e8c

jeevatkm added a commit that referenced this issue Oct 16, 2019

#88 progress of adding tb 68 plus version

1de5eb2

jeevatkm added a commit that referenced this issue Jan 12, 2020

#88 progress of fixing rwh preferences compability issues

3fc75d3

jeevatkm mentioned this issue Mar 4, 2020

Added support TB 68+ #96

Merged

jeevatkm closed this as completed in #96 Mar 4, 2020

Add support for TB 68.0 #88

Add support for TB 68.0 #88

Comments

jeevatkm commented Sep 2, 2019 • edited Loading

jeevatkm commented Sep 2, 2019

wikiaal commented Sep 17, 2019

WesleyGeneroso95 commented Sep 19, 2019

FxRe commented Sep 19, 2019

wikiaal commented Sep 21, 2019

FxRe commented Sep 21, 2019 • edited Loading

jeevatkm commented Sep 23, 2019

wikiaal commented Sep 24, 2019 • edited Loading

insekt commented Oct 9, 2019

dpate71 commented Oct 12, 2019

athanas55 commented Oct 14, 2019

insekt commented Oct 14, 2019 • edited Loading

jeevatkm commented Oct 15, 2019

wikiaal commented Oct 15, 2019

jeevatkm commented Oct 15, 2019

wikiaal commented Oct 15, 2019

insekt commented Oct 15, 2019

zdenekvecera commented Oct 15, 2019

ghost commented Oct 15, 2019

WesleyGeneroso95 commented Oct 15, 2019

athanas55 commented Oct 15, 2019

wikiaal commented Oct 15, 2019

m-i-k-e-y commented Oct 15, 2019

alphp commented Oct 15, 2019

jeevatkm commented Oct 17, 2019

jeevatkm commented Oct 20, 2019

wikiaal commented Oct 20, 2019 • edited Loading

jeevatkm commented Oct 20, 2019

zdenekvecera commented Oct 20, 2019

m-i-k-e-y commented Oct 20, 2019

wikiaal commented Oct 20, 2019 • edited Loading

tidebre67 commented Oct 20, 2019

ghost commented Oct 20, 2019 • edited by ghost Loading

wikiaal commented Oct 20, 2019 • edited Loading

athanas55 commented Oct 24, 2019

jc97 commented Dec 27, 2019

netjeff commented Jan 25, 2020

jeevatkm commented Mar 2, 2020

wikiaal commented Mar 3, 2020

jeevatkm commented Sep 12, 2021

jeevatkm commented Sep 2, 2019 •

edited

Loading

FxRe commented Sep 21, 2019 •

edited

Loading

wikiaal commented Sep 24, 2019 •

edited

Loading

insekt commented Oct 14, 2019 •

edited

Loading

wikiaal commented Oct 20, 2019 •

edited

Loading

wikiaal commented Oct 20, 2019 •

edited

Loading

ghost commented Oct 20, 2019 •

edited by ghost

Loading

wikiaal commented Oct 20, 2019 •

edited

Loading