Fix doubled arguments generated in bosl2_generator.py

[ssuchter]

The raw output of bosl2_generator.py generates some incorrect output. For example, at the moment, this code is produced in bosl2/distributors.py:

def __init__(self, path=None, n=None, spacing=None, sp=None, dist=None, rotate_children=None, dist=None, closed=None, p=None, **kwargs):
       super().__init__("path_copies", {"path" : path, "n" : n, "spacing" : spacing, "sp" : sp, "dist" : dist, "rotate_children" : rotate_children, "dist" : dist, "closed" : closed, "p" : p, **kwargs})

The argument dist=None is listed twice in the __init__ method declaration and in the call to super().__init__. This is a bug.

[jeff-dh]

The issue is, that this seems to be "legal" in OpenSCAD but not in Python. The OpenSCAD code really contains these double parameters.
For now I just deleted the second occurrence of the parameter. This works fine, but it actually changes the signature of the corresponding function. Up until now I couldn't come up with a better solution.

If that's the solution, we could take care of it in

SolidPython/solid2/extensions/openscad_extension_generator.py

Line 41 in 9482e85

def generateCallable(c):

I did not had a closer look at it: why are there double parameters in openscad at all? I assume for convenience, but I did not had a closer look at it, what's the semantic behind it?

[jeff-dh]

Btw: this is not bosl2_generator.py but openscad_extensions_generator.py

[ssuchter]

I think it's non-sensical to have double parameters in OpenSCAD, I just don't think there's any validation. I tested this code:

module draw_cube(a, b, a) {
    cube([a, b, a]);
}

draw_cube(1, 2, 3);

It produced a rectangular prism with sides 1, 2, and 1. So while the later duplicate arguments can be specified, they cannot actually be read inside the function. (As I'd kind of expect...)

Since we want solid2 to be robust to whatever upstream BOSL2 feeds it, I think the right thing to do is to change the code generation to match the manual fixes you've had to do.

| Btw: this is not bosl2_generator.py but openscad_extensions_generator.py

Understood, I was just focusing the issue report on the entry point rather than the root cause. Thanks, though.

[jeff-dh]

Nonsense.....sorry

[jeff-dh]

But what about this:

https://github.com/revarbat/BOSL2/blob/bfa5fbc81aa2cbdc177e839f68baa62d1ae09b57/distributors.scad#L1480

[jeff-dh]

I added a line to the genrator(s) to remove duplicates from the parameter list.

so the genrator(s) do the formerly manual tweaking now.

So I think we can close this issue, right?

[ssuchter]

Yeah, I also had a change that is functionally equivalent to your change, I can abandon mine.