Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping bosl2 version #50

Merged

Conversation

alextigernick
Copy link

I wanted bosl2's new align feature so I bumped the submodule version and ran the generator. I don't know if this repo has a standard process for that 🤷

align seems to work great now.

@jeff-dh
Copy link
Owner

jeff-dh commented Nov 2, 2023

👍

I'll have a look at it soon....

@jeff-dh
Copy link
Owner

jeff-dh commented Nov 13, 2023

I have a couple of thoughts about it:

  • I don't like the actual design, that we need to "repackage" solidpython to update bosl2
  • furthermore bosl2 makes backwards incompatible changes

To achieve a backwards compatible and stable library I'm thinking about pining to bosl2 version that gets shipped with solidpython and add a mechanism to use an external solidpython extension to get the latest bosl2 library.

Up until now its just a warm up of and old idea (this situation happened a couple of times in the last 2 years).

I need to think about it a little more how I want to handle it.

@jeff-dh jeff-dh merged commit ce36f06 into jeff-dh:master-2.0.0-beta-dev Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants