-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab-bag of cosmetic changes #134
Conversation
In many places (mostly constructors) functions were defined with begin end blocks, which is unusual and makes it harder to pick out function definitions.
What's the deal with |
Looks good Kyle. We might want to search for dead code some time too. @rgiordan will know about |
Grab-bag of cosmetic changes
Thanks for doing all this, @kbarbary ! |
Should probably move |
Grab-bag of cosmetic changes Former-commit-id: 4844d43
This PR contains no changes in functionality. Rather, these are changes to better conform to Julia conventions and changes to make the code easier to understand. I was able to clear up a few TODOs in the code along the way. The commit messages are a pretty good summary of the changes, but here's a bit more:
Minor:
@doc
macro everywhere; not needed on Julia 0.4Int64
->Int
everywhere. More correct (...if we ever ran on 32-bit) and shorterfunction
keyword for multi-line constructors rather thanbegin ... end
block.benchmark_elbo.jl
andbenchmark_elbo_with_hessian.jl
scripts; they were almost identical.More significant:
ParamSet
type definitions rather than using metaprogramming to define them. Only slightly longer and much more understandable.src
directory on the Julia load path. This makes it a little more obvious what namespace things are defined in.Files containing submodules are in
CamelCase.jl
whereas files that are just included into other modules arelowercase_with_underscores.jl
.