This repository has been archived by the owner on Jan 23, 2018. It is now read-only.
Actually build the library to include changes from #1 and #2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, my bad, I should have caught that. Your contributions are appreciated!! 🌠 👍 |
|
Pushed version |
|
@gabro I can add you as a maintainer of this repo if you have other changes in mind, let me know 😄 |
|
@jeffcarp sure, why not ^^ I'm using this component in a project I'm working on right now, so I'll probably add more functionalities as I need them. |
|
Awesome! Added! This weekend I'd like to try to set up better integration testing for this repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try again. Same as #3 but this time I built the correct version hopefully...