Start of refactor to turn maverick into a plug library #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
How are you planning on using the Api module defined by the user's use Maverick.Api as its own plug? I had pictured this module as the place where you define your application's full Plug pipeline, so having the Api be itself callable as a plug is making me wonder where you'd include that?
| end | ||
| end | ||
|
|
||
| describe "ssl" do |
There was a problem hiding this comment.
can we comment these out so we know to refactor them to accommodate how Plug lets you set up a server using SSL?
jeffgrunewald
approved these changes
Jan 25, 2021
| Module.register_attribute(__MODULE__, :maverick_routes, accumulate: true) | ||
| Module.put_attribute(__MODULE__, :maverick_route_scope, unquote(scope)) | ||
|
|
||
| @on_definition Maverick | ||
| @before_compile Maverick | ||
|
|
||
| def call(%Plug.Conn{private: %{maverick_route: route}} = conn, _opts) do |
added 6 commits
February 8, 2021 21:15
bbalser
force-pushed
the
embrace_the_plug
branch
from
46d6473
to
8e2d0ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.