Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: read ECONNRESET #89

Closed
jlarmstrongiv opened this issue Jun 28, 2022 · 3 comments
Closed

Error: read ECONNRESET #89

jlarmstrongiv opened this issue Jun 28, 2022 · 3 comments

Comments

@jlarmstrongiv
Copy link
Contributor

It seems that typesync experiences intermittent connection issues often. Having a system to back off and retry would be nice.

✖  read ECONNRESET
Stack:
Error: read ECONNRESET
    at TLSWrap.onStreamRead (node:internal/stream_base_commons:220:20)
npm ERR! Lifecycle script `typesync:check` failed with error: 
npm ERR! Error: command failed 
npm ERR!   in workspace: @universaljs/is@1.0.0 
npm ERR!   at location: /home/ubuntu/actions-runner/_work/project
@jeffijoe
Copy link
Owner

You're not wrong 😅

I never thought about it because it hasn't happened to me yet.

@jlarmstrongiv
Copy link
Contributor Author

I’ve been building my own personal monorepo with several packages and apps—unfortunately, typesync crashes with that error more than it passes 😅

I saw https://github.com/jeffijoe/typesync/blob/master/src/npm-client.ts and think something like https://www.npmjs.com/package/axios-retry could fit nicely

@jeffijoe
Copy link
Owner

I've been meaning to swap out axios for [npm-registry-fetch](https://github.com/npm/npm-registry-fetch) which I believe may include retries, but not sure.

I haven't had time to work on OSS for a while though.

jeffijoe added a commit that referenced this issue Apr 30, 2023
@jeffijoe
feat: use npm-registry-fetch
2b09789 
This will get us authentication and registry selection for free.

Closes #89
jeffijoe added a commit that referenced this issue Apr 30, 2023
@jeffijoe
feat: use npm-registry-fetch
d9a042b 
This will get us authentication and registry selection for free.

Closes #89
jeffijoe added a commit that referenced this issue Apr 30, 2023
@jeffijoe
feat: use npm-registry-fetch
84e8f2d 
This will get us authentication and registry selection for free.

Closes #89 and #67
@jeffijoe jeffijoe mentioned this issue Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffijoe @jlarmstrongiv