Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeSync work without the typespublisher resource + use npm-registry-fetch #97

Merged
merged 2 commits into from Apr 30, 2023

Conversation

jeffijoe
Copy link
Owner

Since Microsoft removed the typespublisher resource that TypeSync relies on as a type definition source, TypeSync stopped working.

TypeSync has been updated to no longer depend on that resource, and instead depends solely on the npm registry. This does mean that we lose the ability to semi-detect unused typings, since the "globals" list is not available to us anymore, so that feature has been removed.

Additionally, we are now using npm-registry-fetch which should give us authentication, retries, and registry selection for free.

Closes #96, #89, and #67

This will get us authentication and registry selection for free.

Closes #89 and #67
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 100.0%. Remained the same when pulling 4729e49 on fix/syncing into 7227d67 on master.

@jeffijoe jeffijoe merged commit e223fb6 into master Apr 30, 2023
10 checks passed
@jeffijoe jeffijoe deleted the fix/syncing branch April 30, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typesync throwing getaddrinfo ENOTFOUND typespublisher.blob.core.windows.net
2 participants